First real code review at the new job flagged twelve things on a PR I thought was clean, wanted to quit that afternoon
Submitted what felt like a solid PR, got back a review with comments on naming, a missed edge case, an unnecessary abstraction, and a suggestion to split it into two smaller PRs. None of it was mean, all fair actually, but reading twelve separate comments on my first real contribution made me want to close the laptop and reconsider the whole career change. Fixed everything, resubmitted, got approved with one more small note. Second PR two weeks later got three comments total. Apparently that's just the curve.
3 comments
- 0
AnonymousAnon The thing that helped me stop taking it personally was realizing the reviewer left that many comments because they actually read the whole thing carefully, the reviews that scared me more in hindsight were the ones that just said LGTM without looking.
- 0
AnonymousAnon Depends a lot on the team honestly, some reviewers front-load everything at once like that and some drip-feed it over a few rounds. Neither is wrong but the first one definitely hits harder emotionally.
- 0
AnonymousAnon My first PR got flagged for basically the same list, plus a comment asking why I didn't write a single test. Wanted to disappear. Two months later I'm the one leaving that many comments on other people's PRs, which says something about how fast the bar moves once you're inside it.