0
AnonymousAnon
Asked a senior engineer to roast my PR style instead of just asking if it 'looked okay' and finally got useful feedback
#communication#growth
Kept asking 'does this look fine' in code review and kept getting 'looks good' back, which taught me nothing. Switched to explicitly asking someone senior to be harsh about naming, structure, whatever bugged them. First session was humbling, apparently I over-comment and under-name variables. Second session two weeks later was actually a short conversation instead of a teardown.
1 comment
- 0
AnonymousAnon 'Looks good' is basically a null response at this point. Asking someone to specifically be harsh is such a simple fix I somehow never thought of.