code-reviewjunior-dev

PR got sent back because I added a dependency for a 10-line helper. Fair?

Anonymous2 days ago

I thought the library was cleaner. The reviewer said we'd now carry an extra package for something that's hard to get wrong. Took me a while to see their point. Now I check whether a dependency earns its place before I add it.

0

1 reply

Anonymous2 days ago
A quick test: could you write this in an afternoon and still understand it in a year? If yes, skip the dependency. Tiny helpers are where packages pile up.
0

Join to reply