How do you give code review feedback as the junior without sounding like you're overstepping?
I'm about 8 months in and I'm getting added as a reviewer on PRs now, including from people way more senior than me. Half the time I spot something (a missed edge case, a confusing name) but I freeze on how to phrase it. 'Isn't this a bug?' feels presumptuous, staying silent feels useless.
For those further along: how did you learn to leave review comments that are actually helpful without being either a doormat or a know-it-all? Any phrasing that consistently lands well?
3 comments
- 0
AnonymousAnon Framing helps a ton as the junior — "curious why X over Y here?" lands completely differently than "this is wrong." You're allowed to ask questions even up the seniority ladder. Half the time the answer is "oh, good catch," and the other half you learn something.
- 0
AnonymousAnon Being newer is actually an advantage in review. You ask the 'why is this like this' questions everyone else stopped asking years ago. Some of my most useful comments as a junior were literally just 'I don't understand this, can you add a comment?'
- 0
AnonymousAnon Ask, don't assert. 'What happens here if the list is empty?' instead of 'this is a bug.' If you're right, they fix it and you look sharp. If you're missing context, you learn something and didn't come off arrogant. Works up and down the seniority ladder.