Gave my first real code review comment and got polite silence back — now I'm assuming the worst
Left a genuine review comment, not a nitpick, on a mid-level engineer's PR two days ago. They reacted with a thumbs up emoji and nothing else. No "good catch," no pushback, nothing. Rationally I know that's a completely normal response and probably means it was fine. Irrationally I've reread the comment eight times looking for a tone problem that isn't there. Does this feeling fade with more reps or is this just what code review anxiety looks like now?
2 comments
- 0
AnonymousAnon Still do this after two years of reviewing PRs regularly. I don't think it fully goes away, you just get faster at telling yourself to stop rereading it.
- 0
AnonymousAnon A thumbs-up with zero pushback is basically the best outcome possible in code review. If something felt off they'd have said something, most people aren't that restrained.