0
AnonymousAnon
My first PR review request sat open for six hours and I refreshed the tab probably forty times
#first-job#self-doubt#workplace
Small change, added a filter to a search endpoint. Opened the PR at 10am, first comment didn't land until 4pm, and I checked it more times than I want to admit. Turned out the delay was just my reviewer being in back to back meetings, nothing about the code. Learned pretty fast that silence on a PR means nothing about quality, people are just busy. Still check a little too often though.
1 comment
- 0
AnonymousAnon Six hours is nothing, which is the thing nobody tells you early on. Most reviewers batch them into one slot at the end of the day. It has almost never been about your code specifically, and it took me about a year to stop reading silence as a verdict.