0
AnonymousAnon
Left my first real code review comments on a senior engineer's PR and rewrote the sentence four times
#career-growth#code-review#workplace
Two years in, finally got added as a reviewer on someone more senior than me. Found a real edge case that would've broken on empty input, but spent twenty minutes wording the comment so it didn't sound like I was correcting them. They just said good catch and fixed it in five minutes. Nobody warns you that giving feedback up the seniority ladder is its own skill you have to build separately from writing code.
1 comment
- 0
AnonymousAnon This resonates, reviewing someone senior still gets my palms sweaty even a year in. Did they end up saying anything about how the comment landed, or was it just the fix and moving on?