code-reviewfeedbackfirst-job
First time leaving review comments on a staff engineer's PR and I rewrote the same three sentences for twenty minutes
Anonymous
Small thing, a naming inconsistency and a missing null check. I typed "nit: ", deleted it, typed "maybe consider", deleted that, added and removed "actually" about five separate times trying to sound appropriately junior-but-not-a-pushover. Finally sent something plain and short. He replied nine minutes later: "good catch, fixed." That was it. The whole twenty minutes of agonizing was entirely mine, the actual interaction didn't care at all.
0