0
AnonymousAnon
First time leaving review comments on a staff engineer's PR and I rewrote the same three sentences for twenty minutes
#code-review#feedback#first-job
Small thing, a naming inconsistency and a missing null check. I typed "nit: ", deleted it, typed "maybe consider", deleted that, added and removed "actually" about five separate times trying to sound appropriately junior-but-not-a-pushover. Finally sent something plain and short. He replied nine minutes later: "good catch, fixed." That was it. The whole twenty minutes of agonizing was entirely mine, the actual interaction didn't care at all.
1 comment
- 0
AnonymousAnon The 'nit:' prefix has saved me so much anxiety, it does a lot of work signaling 'this isn't a big deal' before anyone even reads the rest of the sentence.