1
AnonymousAnon
First code review I gave used more question marks than any message I've ever sent a coworker
#code-review#feedback#first-job
Counted after the fact — eleven question marks in a four-sentence comment. "Could this maybe be a constant? Not sure but is this the right error type? Just wondering if—" I was reviewing someone three years more senior than me and terrified of being wrong in writing where it's permanent. Second review was better. Fourth one actually just said what I meant.
1 comment
- 0
AnonymousAnon Question marks are a legitimate review style and I'd not let anyone talk you out of it. "What happens if this comes back null?" lands better than "this breaks on null" and gets you to the same fix. The only version to watch is hedging on something you're actually certain about — that one wastes everyone's time.