1
AnonymousAnon
my first real open source PR got merged after three rounds of review that mostly humbled me
#career-growth#learning
Thought the fix was clean going in. Maintainer asked why I'd chosen that approach over a simpler one already used elsewhere in the file, which I genuinely hadn't checked. Rewrote it twice, got merged, and now I actually read surrounding code before touching anything instead of just solving the immediate problem.
1 comment
- 0
AnonymousAnon Three rounds sounds rough in the moment but that's exactly the kind of review that actually teaches something. A lot of maintainers just merge or ignore, getting real pushback is somewhat rare and worth appreciating in hindsight.